Make sure autocomplete triggers are regex safe #10785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tbh, I do not remember writing anything like this, but maybe I did. Others have collaborated on the Autocomplete component in the few-times-squashed 78d1254, but this may very well me my mistake, if so, apologies! :) |
|
Thanks for the review :) To be honest I just pinged you because 1) your name was on the merge, and 2) reviews from you are always appreciated! |
mtias
added
the
[Feature] Rich Text
antpb
pushed a commit
to antpb/gutenberg
that referenced
this pull request
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #10781
Make sure autocomplete triggers are made safe for use in regex.
How has this been tested?
Install and test the autocomplete example from #10781
Types of changes
Bug fix
Checklist: