Enforce text color on inline boundaries to ensure contrast #10623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvanpatten
added
[Type] Enhancement
|
OMG you are the best. |
tofumatt
approved these changes
Oct 15, 2018
There was a problem hiding this comment.
Pinged @karmatosed or @sarahmonster for a review that this is alright–the concept we totally should do, but if you have specific design thoughts that won't require too much extra complexity let us know! 😄
| // Link inline boundaries get special colors. | ||
| a[data-mce-selected] { | ||
| box-shadow: 0 0 0 1px $blue-medium-100; | ||
| background: $blue-medium-100; |
There was a problem hiding this comment.
Is there sufficient colour contrast here? To my eyes it's fine, but then I have good eyesight and am right now using my 5K monitor 🤷♂️
There was a problem hiding this comment.
Good catch; updated this to $blue-medium-900 to achieve WCAG AA compatibility.
Thanks for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9508.
This PR ensures active/focussed inline boundaries have a text color to prevent color contrast issues.
I also lightly refactored the text inline boundaries to consolidate some CSS.