Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Add bare handling for lint-js script (no zero config) #10504

Merged
merged 2 commits into from
Oct 11, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Oct 11, 2018

Description

This PR adds wp-scripts lint-js script to the @wordpress/scripts package. The idea is to have it working with #7965 which will offer zero config support when it's ready. At the moment this is just proxy over eslint so it only makes it easier to maintain your dependencies for tools.

How has this been tested?

npm run lint-js inside Gutenberg should work as before.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added [Status] In Progress Tracking issues with work in progress [Type] Build Tooling Issues or PRs related to build tooling labels Oct 11, 2018
@gziolo gziolo added this to the 4.1 milestone Oct 11, 2018
@gziolo gziolo self-assigned this Oct 11, 2018
@gziolo gziolo removed the [Status] In Progress Tracking issues with work in progress label Oct 11, 2018
@@ -34,8 +34,10 @@
"@wordpress/babel-preset-default": "file:../babel-preset-default",
"@wordpress/jest-preset-default": "file:../jest-preset-default",
"@wordpress/npm-package-json-lint-config": "file:../npm-package-json-lint-config",
"babel-eslint": "8.0.3",
Copy link
Member Author

@gziolo gziolo Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to bump babel-eslint and eslint but it throws an error with the latest version. We should tackle it separately.

Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@gziolo gziolo merged commit 8d4e258 into master Oct 11, 2018
@gziolo gziolo deleted the add/scripts-lint-js branch October 11, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants