Allow link to be edited while selection is collapsed #10372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
reviewed
Oct 10, 2018
| expect( result ).toEqual( expected ); | ||
| expect( result ).not.toBe( record ); | ||
| expect( getSparseArrayLength( result.formats ) ).toBe( 3 ); | ||
| } ); |
There was a problem hiding this comment.
What happens if applyFormat is called with no existing format and a collapsed selection? Should we have a unit test for this case?
There was a problem hiding this comment.
Then nothing happens, but sure we can have a test for it.
There was a problem hiding this comment.
I will do it now and merge PR afterward 👍
There was a problem hiding this comment.
I hope this works for you @noisysocks: 9221a33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10368. Adds logic to applyFormat to edit the format around the caret if it is of the same type. This logic is already present in
removeFormat. Adds e2e test.How has this been tested?
See #10368.
Screenshots
Types of changes
Checklist: