Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dashes instead of underscores for consistency with other actions #10256

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Use dashes instead of underscores for consistency with other actions #10256

merged 1 commit into from
Oct 4, 2018

Conversation

danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Sep 30, 2018 •
edited
Loading

@danielbachhuber danielbachhuber added REST API Interaction Related to REST API [Package] Editor /packages/editor labels Sep 30, 2018
@danielbachhuber danielbachhuber added this to the 4.0 milestone Sep 30, 2018
@danielbachhuber danielbachhuber requested review from noisysocks, oandregal and aduth and removed request for noisysocks September 30, 2018 14:17
youknowriad
youknowriad approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I don't have strong opinions on naming things and we could argue that this property was only used by Gutenberg itself and not third-party developers yet as not documented. So I'm approving.

@danielbachhuber danielbachhuber merged commit fce0317 into master Oct 4, 2018
@danielbachhuber danielbachhuber deleted the 7667-use-dashes branch October 4, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@oandregal oandregal Awaiting requested review from oandregal

@aduth aduth Awaiting requested review from aduth

Assignees
No one assigned
Labels
[Package] Editor /packages/editor REST API Interaction Related to REST API
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbachhuber @youknowriad