Editor: Changed createObjectUrl to createBlobURL #10135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c935581
to
52cbb09
Compare
| @@ -131,7 +132,7 @@ export function mediaUpload( { | |||
|
|
|||
| // Set temporary URL to create placeholder media file, this is replaced | |||
| // with final file from media gallery when upload is `done` below | |||
| filesSet.push( { url: window.URL.createObjectURL( mediaFile ) } ); | |||
| filesSet.push( { url: createBlobURL( mediaFile ) } ); | |||
There was a problem hiding this comment.
Each call to createBlobURL should eventually have a revokeBlobURL to make sure the file used by the blob is removed from the memory when not need anymore. In this case, revokeBlobURL should be called as soon as createMediaFromFile finishes with success or fails.
jorgefilipecosta
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for the work started by @caxco93 in #7734.
Description
Changed createObjectUrl to createBlobURL from the
@wordpress/editorpackage.How has this been tested?
Included tests and manually
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: