Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wp_block post type adds unnecessary rewrite rules #8233

Closed
swissspidy opened this issue Jul 26, 2018 · 0 comments · Fixed by #8260
Closed

wp_block post type adds unnecessary rewrite rules #8233

swissspidy opened this issue Jul 26, 2018 · 0 comments · Fixed by #8260
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@swissspidy
Copy link
Member

Describe the bug

When installing Gutenberg, it adds a bunch of unnecessary rewrite rules for the wp_block post type.

To Reproduce
Steps to reproduce the behavior:

  1. Install and activate Gutenberg
  2. Run wp rewrite list
  3. Notice that the default rewrite rules for the post type are listed

Expected behavior
No rewrite rules are added.

For this, rewrite needs to be explicitly set to false when registering a post type.

See https://developer.wordpress.org/reference/functions/register_post_type/
@swissspidy swissspidy added [Type] Bug An existing feature does not function as intended [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) labels Jul 26, 2018
@danielbachhuber danielbachhuber added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jul 27, 2018
chrisvanpatten added a commit to TomodomoCo/gutenberg that referenced this issue Jul 27, 2018
@chrisvanpatten
Don't register rewrite rules for the wp_blocks post type; fixes WordP…
df5bfb2 
…ress#8233
@chrisvanpatten chrisvanpatten mentioned this issue Jul 27, 2018
Merged
4 tasks
pento pushed a commit that referenced this issue Jul 30, 2018
@chrisvanpatten @pento
Don't register rewrite rules for the wp_blocks post type (#8260)
72384a6 
Fixes #8233.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't register rewrite rules for the wp_blocks post type TomodomoCo/gutenberg
2 participants
@danielbachhuber @swissspidy