Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in separators to block sidebar like document sidebar #7686

Closed
chrisvanpatten opened this issue Jul 3, 2018 · 5 comments
Closed

Add in separators to block sidebar like document sidebar #7686

chrisvanpatten opened this issue Jul 3, 2018 · 5 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.

Comments

@chrisvanpatten
Copy link
Contributor

Currently, accordion panels in the block inspector are unique from the document inspector, because they don't have separators.

accordion

This gets especially confusing when you have blocks with many options, because the panels can blend together, for example in one of our custom blocks:

untitled____add_new_page mindful _wordpress

While I suspect this was originally an intentional choice (and it works well enough with core blocks, which are relatively option-light), I think greater consistency between Document and Block Inspectors could be beneficial, and improve 'scanability'.

@chrisvanpatten
Copy link
Contributor Author

(I see now this relates to #7063, which I also commented on… d'oh. Leaving this open for now as it's a little more specific, and I'm also going to work on a PR.)

@ajitbohra ajitbohra added [Type] Enhancement A suggestion for improvement. [Feature] Inspector Controls The interface showing block settings and the controls available for each block Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Jul 3, 2018
@Soean Soean added the Needs Design Feedback Needs general design feedback. label Jul 3, 2018
@karmatosed karmatosed removed Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement. [Feature] Inspector Controls The interface showing block settings and the controls available for each block labels Jul 3, 2018
@karmatosed karmatosed changed the title Separators between accordion panels in the block inspector Add in separators to block sidebar like document sidebar Jul 3, 2018
@karmatosed
Copy link
Member

@chrisvanpatten I hope it was ok but I adjusted the title to make sure it was I think what you wanted? I agree that both should reflect the same style. I don't see it as a design decisions that means we shouldn't implement.

@ajitbohra just a little note on good first issue, totally this could be but let's make sure we get design decisions in first to ensure those coming into that first issue are able to just work on it. Also I think this maybe is Chrome but those labels are a little confusing in this case.

@karmatosed karmatosed added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. and removed Needs Design Feedback Needs general design feedback. labels Jul 3, 2018
@chrisvanpatten
Copy link
Contributor Author

@karmatosed thanks! 4th of July prep got me sidetracked but I’ll work up a PR ASAP.

@karmatosed
Copy link
Member

@chrisvanpatten awesome thanks and happy 4th of July for yesterday!

@chrisvanpatten
Copy link
Contributor Author

Finally pushed up a commit for this! 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants