Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor Navigation Panel - Allow 'esc' to close the panel. #29530

Closed
Addison-Stavlo opened this issue Mar 3, 2021 · 3 comments
Closed

Site Editor Navigation Panel - Allow 'esc' to close the panel. #29530

Addison-Stavlo opened this issue Mar 3, 2021 · 3 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@Addison-Stavlo
Copy link
Contributor

What problem does this address?

The site editor navigation panel has no keyboard shortcut to close the panel. In keyboard flows a user must navigate back to the toggle button to close the panel. For reasons noted in #29529 the interaction with that toggle button may also be confusing.

Screen Shot 2021-03-03 at 1 06 34 PM

What is your proposed solution?

Allow 'esc' key to close the navigation panel while it is focused.
@Addison-Stavlo Addison-Stavlo added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Full Site Editing [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 3, 2021
@Addison-Stavlo Addison-Stavlo mentioned this issue Mar 3, 2021
Closed
@Quintis1212
Copy link
Contributor

Hello ) I think I can implement this )

@Quintis1212 Quintis1212 mentioned this issue Mar 3, 2021
Merged
@Quintis1212
Copy link
Contributor

Hello ) I created PR to your issue

Addison-Stavlo pushed a commit that referenced this issue Mar 10, 2021
@Quintis1212
Accessibility improvement on #29530 issue (#29534)
587134c 
* accessibility improvement on #29530 issue

* accessibility improvement on #29530 issue ( improved event listener function )

* Update index.js

removed not optimized function

* Function  optimized

* Adding event listener to div element

* removed function

* Added close on esc button function in nav panel

* Removed empty line

* Updated WordPress dependencies group

* Added role="navigation"

* Disable role check in div tag
@dependabot dependabot bot mentioned this issue Mar 11, 2021
Closed
@Addison-Stavlo
Copy link
Contributor Author

closed with the above PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Addison-Stavlo @Quintis1212