Remove unneeded pattern overrides translation strings (#59269)

Co-authored-by: kevin940726 <[email protected]> Co-authored-by: talldan <[email protected]>
WordPress · Feb 22, 2024 · c62690f · c62690f · github-actions · Feb 22, 2024
1 parent 270ff99
commit c62690f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 22 deletions.
diff --git a/packages/patterns/src/components/partial-syncing-controls.js b/packages/patterns/src/components/partial-syncing-controls.js
@@ -17,7 +17,7 @@ import { PARTIAL_SYNCING_SUPPORTED_BLOCKS } from '../constants';
 
 function PartialSyncingControls( { name, attributes, setAttributes } ) {
  const syncedAttributes = PARTIAL_SYNCING_SUPPORTED_BLOCKS[ name ];
- const attributeSources = Object.keys( syncedAttributes ).map(
+ const attributeSources = syncedAttributes.map(
  ( attributeName ) =>
  attributes.metadata?.bindings?.[ attributeName ]?.source
  );
@@ -36,7 +36,7 @@ function PartialSyncingControls( { name, attributes, setAttributes } ) {
  };
 
  if ( ! isChecked ) {
- for ( const attributeName of Object.keys( syncedAttributes ) ) {
+ for ( const attributeName of syncedAttributes ) {
  if (
  updatedBindings[ attributeName ]?.source ===
  'core/pattern-overrides'
@@ -56,7 +56,7 @@ function PartialSyncingControls( { name, attributes, setAttributes } ) {
  return;
  }
 
- for ( const attributeName of Object.keys( syncedAttributes ) ) {
+ for ( const attributeName of syncedAttributes ) {
  if ( ! updatedBindings[ attributeName ] ) {
  updatedBindings[ attributeName ] = {
  source: 'core/pattern-overrides',

diff --git a/packages/patterns/src/constants.js b/packages/patterns/src/constants.js
@@ -1,8 +1,3 @@
-/**
- * WordPress dependencies
- */
-import { __ } from '@wordpress/i18n';
-
 export const PATTERN_TYPES = {
  theme: 'pattern',
  user: 'wp_block',
@@ -22,18 +17,8 @@ export const PATTERN_SYNC_TYPES = {
 
 // TODO: This should not be hardcoded. Maybe there should be a config and/or an UI.
 export const PARTIAL_SYNCING_SUPPORTED_BLOCKS = {
- 'core/paragraph': { content: __( 'Content' ) },
- 'core/heading': { content: __( 'Content' ) },
- 'core/button': {
- text: __( 'Text' ),
- url: __( 'URL' ),
- linkTarget: __( 'Link Target' ),
- rel: __( 'Link Relationship' ),
- },
- 'core/image': {
- id: __( 'Image ID' ),
- url: __( 'URL' ),
- title: __( 'Title' ),
- alt: __( 'Alt Text' ),
- },
+ 'core/paragraph': [ 'content' ],
+ 'core/heading': [ 'content' ],
+ 'core/button': [ 'text', 'url', 'linkTarget', 'rel' ],
+ 'core/image': [ 'id', 'url', 'title', 'alt' ],
 };