PagePages: Fix unintended object mutation inside component (#55314)

- Don't reuse references when updating postStatuses - Don't accidentally mutate EMPTY_OBJECT
WordPress · Oct 13, 2023 · c47905f · c47905f · github-actions · Oct 13, 2023
1 parent a54da2d
commit c47905f
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/packages/edit-site/src/components/page-pages/index.js b/packages/edit-site/src/components/page-pages/index.js
@@ -39,13 +39,15 @@ export default function PagePages() {
  } );
  // Request post statuses to get the proper labels.
  const { records: statuses } = useEntityRecords( 'root', 'status' );
- const postStatuses =
- statuses === null
- ? EMPTY_OBJECT
- : statuses.reduce( ( acc, status ) => {
- acc[ status.slug ] = status.name;
- return acc;
- }, EMPTY_OBJECT );
+ const postStatuses = useMemo(
+ () =>
+ statuses === null
+ ? EMPTY_OBJECT
+ : Object.fromEntries(
+ statuses.map( ( { slug, name } ) => [ slug, name ] )
+ ),
+ [ statuses ]
+ );
 
  const queryArgs = useMemo(
  () => ( {