Button block: use early return to optimize save.js. (#29781)

WordPress · Mar 12, 2021 · 27cb4f6 · 27cb4f6
1 parent f8052e1
commit 27cb4f6
Showing 1 changed file with 17 additions and 14 deletions.
diff --git a/packages/block-library/src/button/save.js b/packages/block-library/src/button/save.js
@@ -23,6 +23,11 @@ export default function save( { attributes, className } ) {
  url,
  width,
  } = attributes;
+
+ if ( ! text ) {
+ return null;
+ }
+
  const colorProps = getColorAndStyleProps( attributes );
  const buttonClasses = classnames(
  'wp-block-button__link',
@@ -45,19 +50,17 @@ export default function save( { attributes, className } ) {
  } );
 
  return (
- text && (
- <div { ...useBlockProps.save( { className: wrapperClasses } ) }>
- <RichText.Content
- tagName="a"
- className={ buttonClasses }
- href={ url }
- title={ title }
- style={ buttonStyle }
- value={ text }
- target={ linkTarget }
- rel={ rel }
- />
- </div>
- )
+ <div { ...useBlockProps.save( { className: wrapperClasses } ) }>
+ <RichText.Content
+ tagName="a"
+ className={ buttonClasses }
+ href={ url }
+ title={ title }
+ style={ buttonStyle }
+ value={ text }
+ target={ linkTarget }
+ rel={ rel }
+ />
+ </div>
  );
 }