Try to optimize getClientIdsOfDescendants using memoization. (#40112)

WordPress · Apr 7, 2022 · 10032aa · 10032aa
1 parent ba8b6ef
commit 10032aa
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/packages/block-editor/src/store/selectors.js b/packages/block-editor/src/store/selectors.js
@@ -225,18 +225,21 @@ export const __unstableGetClientIdsTree = createSelector(
  *
  * @return {Array} ids of descendants.
  */
-export const getClientIdsOfDescendants = ( state, clientIds ) => {
- const collectedIds = [];
- for ( const givenId of clientIds ) {
- for ( const descendantId of getBlockOrder( state, givenId ) ) {
- collectedIds.push(
- descendantId,
- ...getClientIdsOfDescendants( state, [ descendantId ] )
- );
+export const getClientIdsOfDescendants = createSelector(
+ ( state, clientIds ) => {
+ const collectedIds = [];
+ for ( const givenId of clientIds ) {
+ for ( const descendantId of getBlockOrder( state, givenId ) ) {
+ collectedIds.push(
+ descendantId,
+ ...getClientIdsOfDescendants( state, [ descendantId ] )
+ );
+ }
  }
- }
- return collectedIds;
-};
+ return collectedIds;
+ },
+ ( state ) => [ state.blocks.order ]
+);
 
 /**
  * Returns an array containing the clientIds of the top-level blocks and