Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HelpHub] Spacer block #289

Closed
11 of 12 tasks
femkreations opened this issue Apr 14, 2022 · 18 comments
Closed
11 of 12 tasks

[HelpHub] Spacer block #289

femkreations opened this issue Apr 14, 2022 · 18 comments
Assignees
Labels
6.0 Changes in 6.0 release 6.1 Changes in 6.1 release 6.3 Changes in 6.3 release block editor Gutenberg related issues medium priority [Status] Done Issue is completed tracking issue Use to track a series of related issues. user documentation (HelpHub) Improvements or additions to end-user documentation

Comments

@femkreations
Copy link
Collaborator

femkreations commented Apr 14, 2022

Article: https://wordpress.org/support/article/spacer-block/

Updating for 6.3

  • Adapt flex child controls for Spacer 49362
  • Add spacing presets to the spacer block 44002

Updating for 6.1

  • Add spacing block supports 43366
  • Remove redundant block name from "settings" panels 40275

Updating for 6.0

  • Add custom units for height and width. 36186
  • Note the resizable box and controls 39577

General

  • Make sure all screenshots are relevant to the latest version
  • Make sure videos are up to date
  • Add ALT tags for the images
  • Make sure the headings are in sentence case
  • Convert all reusable blocks to a ‘regular block’.
  • Update the changelog at the end of the article
@femkreations femkreations added tracking issue Use to track a series of related issues. user documentation (HelpHub) Improvements or additions to end-user documentation block editor Gutenberg related issues 6.0 Changes in 6.0 release labels Apr 14, 2022
@wmjohnston06
Copy link

I am working on this issue during Contributor Day at WordCamp Europe 2022.

@wmjohnston06
Copy link

Suggested change 1: In the first paragraph of the article, update the text to read:

"If you want to have a space between two blocks, the spacer block is what you will use.
A vertical spacer adds space between blocks in a column (as in a page or post).
A horizontal spacer adds space between blocks in a row (as in a Navigation block).

(Note: Using a Navigation block requires a block theme or a theme that has support for template editing.)

Suggested change 2: In the paragraph under the heading "Spacer Settings", change the text

From:
"The Height setting adjusts the height of the space you want to add by typing the number."
To:
"The Height setting adjusts the height of the space. The Width setting adjusts the width of the space. You can adjust the settings by either:

  • Typing the number in the "Spacer Settings" box, or
  • Dragging the handle at the bottom of the spacer (for the vertical spacer) or at the side of the spacer (for the horizontal spacer).

@luminuu
Copy link
Member

luminuu commented Jun 2, 2022

Screenshots for 6.0

More options
grafik

@wmjohnston06
Copy link

Make sure the headings are in sentence case
These headings should be changed:

  • Block toolbar
  • More options
  • Block settings
  • Spacer settings

@bph bph added the has-screenshots Screenshots are available in the comments. label Jun 14, 2022
@cavalierlife
Copy link

I'd like to work on this one.

@cavalierlife
Copy link

cavalierlife commented Sep 11, 2022

Screenshots for 6.0

Add new spacer block with /

Image

Spacer More Options:

Image

The rest of the current screenshots are still valid for 6.0

@cavalierlife
Copy link

@femkreations These screenshots are ready to review.

@wmjohnston06
Copy link

wmjohnston06 commented Sep 11, 2022 via email

@cavalierlife
Copy link

No need to be embarrassed, @wmjohnston06 . And since I'm a new contributor, it's always possible I shouldn't have interrupted your process. I have no idea! Either way, we'll call this a team effort, right? :)

@femkreations
Copy link
Collaborator Author

Thanks @wmjohnston06 and @cavalierlife for adding in the content for the previous versions.

I am adding in the tasks for 6.1.

Notes

  1. We are not adding updates for the Block settings as we are revamping the block settings for all the block articles
  2. Pls make 6.1 updates first and then move into 6.0.
  3. For 6.0, you can pick the screenshots added in the comments previously.

@chrisjangl
Copy link

I can help out here, @zzap.

@femkreations
Copy link
Collaborator Author

moving this into the 6.2 Project board

@jomarieminney
Copy link

I can take this one if @chrisjangl is swamped.

@zzap zzap mentioned this issue May 30, 2023
13 tasks
@femkreations femkreations added good first issue Good for newcomers 6.3 Changes in 6.3 release and removed has-screenshots Screenshots are available in the comments. labels Jul 12, 2023
@femkreations
Copy link
Collaborator Author

Added tasks for 6.3 and moved to 6.3 project board. @jomarieminney Pls let me know if you want to continue working on this.

@zzap zzap added the [Status] To do Issue marked as Todo label Aug 23, 2023
@gabrlknght
Copy link

/assign

@zzap
Copy link
Member

zzap commented Aug 24, 2023

Hey @gabrlknght, this issue is already assigned to @chrisjangl.
A maintainer can also add you to the list of assignees or swap you with the current assignee. Or you can take a look at other unassigned issues we have.

@zzap zzap removed the good first issue Good for newcomers label Oct 2, 2023
@zzap
Copy link
Member

zzap commented Oct 24, 2023

Spacer Block Settings Panel

@zzap zzap self-assigned this Oct 24, 2023
@github-actions github-actions bot added [Status] In progress Issue is in progress and removed [Status] To do Issue marked as Todo labels Oct 24, 2023
@zzap
Copy link
Member

zzap commented Oct 24, 2023

I updated the article with updates for all versions. Thank you to everyone who contributed, you are heroes ❤️

I just created a new good first issue if anyone wants to go over the screenshots and make sure they are up to date.

#1241

Closing this one now.

@zzap zzap closed this as completed Oct 24, 2023
@github-actions github-actions bot added [Status] Done Issue is completed and removed [Status] In progress Issue is in progress labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.0 Changes in 6.0 release 6.1 Changes in 6.1 release 6.3 Changes in 6.3 release block editor Gutenberg related issues medium priority [Status] Done Issue is completed tracking issue Use to track a series of related issues. user documentation (HelpHub) Improvements or additions to end-user documentation
Projects
Status: Done
Status: Done
Development

No branches or pull requests

9 participants