Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removal of prefix when proxying to another server (#630) #924

Merged
merged 9 commits into from
Apr 23, 2023

Conversation

nudejustin
Copy link
Contributor

Adds a new set of properties to the proxy server settings that allow prefix url rewriting in order to resolve issue #630

Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take a look at my comments

@nudejustin
Copy link
Contributor Author

@StefH The CI linter was flagging the parser method as being too complex now after the changes you suggested above. I've refactored the code a bit further to hopefully make the flow easier to understand at the top level function level, whilst also introducing the change youn suggested in the more specific function. Let me know if you'd prefer this done in a different way than I approached it.

@StefH StefH changed the title #630 Allow removal of prefix when proxying to another server Allow removal of prefix when proxying to another server (#630) Apr 23, 2023
@StefH StefH merged commit 9ef8bd0 into WireMock-Net:master Apr 23, 2023
@StefH StefH added the feature label Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants