Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use try-catch when adding or removing logEntry #848

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Nov 17, 2022

No description provided.

@StefH StefH added the bug label Nov 17, 2022
@StefH StefH self-assigned this Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 72.73% // Head: 72.71% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (eed1646) compared to base (ef5f988).
Patch coverage: 72.72% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
- Coverage   72.73%   72.71%   -0.03%     
==========================================
  Files         215      215              
  Lines        7725     7741      +16     
  Branches      817      817              
==========================================
+ Hits         5619     5629      +10     
- Misses       1857     1863       +6     
  Partials      249      249              
Impacted Files Coverage Δ
src/WireMock.Net/Owin/WireMockMiddleware.cs 80.58% <72.72%> (-1.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@StefH StefH changed the title Use try-catch when removing logEntry Use try-catch when adding or removing logEntry Nov 18, 2022
@StefH StefH merged commit 38634ac into master Nov 21, 2022
@StefH StefH deleted the stef-846-reqlog branch November 21, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant