Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to skip saving the string-response in the logging when using WithBody(Func...) #828

Merged
merged 7 commits into from
Oct 21, 2022

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Oct 13, 2022

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 72.18% // Head: 72.27% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (86b200e) compared to base (3603762).
Patch coverage: 93.75% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
+ Coverage   72.18%   72.27%   +0.08%     
==========================================
  Files         214      214              
  Lines        7684     7712      +28     
  Branches      809      810       +1     
==========================================
+ Hits         5547     5574      +27     
- Misses       1893     1894       +1     
  Partials      244      244              
Impacted Files Coverage Δ
src/WireMock.Net/Matchers/LinqMatcher.cs 74.60% <ø> (ø)
...eMock.Net/Settings/WireMockServerSettingsParser.cs 0.00% <0.00%> (ø)
src/WireMock.Net/ResponseBuilders/Response.cs 92.85% <33.33%> (ø)
src/WireMock.Net/Server/WireMockServer.Admin.cs 67.59% <87.50%> (+0.34%) ⬆️
...k.Net.Abstractions/Admin/Settings/SettingsModel.cs 100.00% <100.00%> (ø)
src/WireMock.Net/Logging/LogEntry.cs 100.00% <100.00%> (ø)
src/WireMock.Net/Models/BodyData.cs 100.00% <100.00%> (ø)
src/WireMock.Net/Owin/WireMockMiddleware.cs 82.10% <100.00%> (+0.09%) ⬆️
src/WireMock.Net/Owin/WireMockMiddlewareOptions.cs 75.00% <100.00%> (+0.92%) ⬆️
...WireMock.Net/ResponseBuilders/Response.WithBody.cs 99.06% <100.00%> (+0.01%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@StefH StefH added feature and removed test labels Oct 15, 2022
@StefH StefH changed the title Add extra unit-test for Response WithBody (dynamic code) Add setting to skip saving the string-response when using WithBody(Func...) Oct 15, 2022
@StefH StefH changed the title Add setting to skip saving the string-response when using WithBody(Func...) Add setting to skip saving the string-response in the logging when using WithBody(Func...) Oct 15, 2022
@StefH StefH merged commit 57115f1 into master Oct 21, 2022
@StefH StefH deleted the stef-826 branch October 21, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant