Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertions for request methods #802

Merged
merged 3 commits into from
Sep 3, 2022

Conversation

rafaelmfonseca
Copy link
Contributor

Hi, i've added some assertions for request methods.

@StefH
Copy link
Collaborator

StefH commented Sep 2, 2022

@rafaelmfonseca
Thank you,

However, one test fails:
Failed WireMock.Net.Tests.FluentAssertions.WireMockAssertionsTests.HaveReceivedACall_UsingConnect_WhenACallWasMadeUsingConnect_Should_BeOK [6 ms]
Error Message:
System.Net.Http.HttpRequestException : CONNECT request must contain Host header.

@rafaelmfonseca
Copy link
Contributor Author

rafaelmfonseca commented Sep 3, 2022

@StefH
Thanks!
I've fixed the UsingConnect() test, except for net452, it's like HttpClient is not sending the request using the method "CONNECT"... I tried a lot of thing but it didn't work. It's weird because with NET461+ it's working, so I assume some internal code of HttpClient changed from NET452 to NET461. Do you have any ideas?

(maybe because "CONNECT" it's a two-way communication, works like a tunnel)

@StefH StefH merged commit 862c04e into WireMock-Net:master Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants