Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WithBody when using Pact and added more nullable annotations #783

Merged
merged 13 commits into from
Aug 11, 2022

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Aug 9, 2022

No description provided.

@StefH StefH added the feature label Aug 9, 2022
@StefH StefH self-assigned this Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #783 (c31e5fb) into master (b1af37f) will increase coverage by 0.08%.
The diff coverage is 73.87%.

@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
+ Coverage   71.97%   72.06%   +0.08%     
==========================================
  Files         209      210       +1     
  Lines        7280     7321      +41     
  Branches      753      762       +9     
==========================================
+ Hits         5240     5276      +36     
- Misses       1810     1815       +5     
  Partials      230      230              
Impacted Files Coverage Δ
...k.Net.Abstractions/Admin/Mappings/WebProxyModel.cs 0.00% <0.00%> (ø)
....Matchers.CSharpCode/Matchers/CSharpCodeMatcher.cs 83.33% <ø> (ø)
src/WireMock.Net/Compatibility/EmptyArray.cs 0.00% <0.00%> (ø)
...WireMock.Net/HttpsCertificate/CertificateLoader.cs 0.00% <0.00%> (ø)
...ck.Net/HttpsCertificate/PublicCertificateHelper.cs 0.00% <0.00%> (ø)
...ireMock.Net/ResponseBuilders/Response.WithProxy.cs 100.00% <ø> (ø)
.../ResponseProviders/DynamicAsyncResponseProvider.cs 0.00% <0.00%> (ø)
...reMock.Net/Server/WireMockServer.ConvertMapping.cs 43.75% <0.00%> (ø)
...rc/WireMock.Net/Settings/WireMockServerSettings.cs 94.59% <0.00%> (-2.63%) ⬇️
...eMock.Net/Settings/WireMockServerSettingsParser.cs 0.00% <0.00%> (ø)
... and 74 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@StefH StefH changed the title More nullable annotations Fix WithBody when using Pact and added more nullable annotations Aug 11, 2022
@StefH StefH merged commit d2a1d0f into master Aug 11, 2022
@StefH StefH deleted the JsonDefaultSettings-774 branch August 11, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant