Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WireMock.Net.xUnit project #759

Merged
merged 5 commits into from
May 21, 2022
Merged

Add WireMock.Net.xUnit project #759

merged 5 commits into from
May 21, 2022

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented May 20, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #759 (e0e0087) into master (ca6c39c) will decrease coverage by 0.08%.
The diff coverage is 52.77%.

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
- Coverage   72.88%   72.79%   -0.09%     
==========================================
  Files         194      195       +1     
  Lines        6919     6955      +36     
  Branches      727      729       +2     
==========================================
+ Hits         5043     5063      +20     
- Misses       1656     1673      +17     
+ Partials      220      219       -1     
Impacted Files Coverage Δ
...reMock.Net.xUnit/TestOutputHelperWireMockLogger.cs 52.77% <52.77%> (ø)
src/WireMock.Net/Server/WireMockServer.Admin.cs 58.59% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6c39c...e0e0087. Read the comment docs.

using WireMock.Logging;
using Xunit.Abstractions;

namespace WireMock.Net.xunit;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the namespace should be WireMock.Net.Xunit to follow the same naming as the xUnit project.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@siewers
Copy link
Contributor

siewers commented May 20, 2022

I guess folders, assembly names etc. should be renamed to Xunit as well :)

@StefH
Copy link
Collaborator Author

StefH commented May 20, 2022

I was doubting about the name.

I see some NuGet packages like xxx.xUnit and xxx.Xunit
image

And xunit itself is named:
image

So what to do ?

@siewers
Copy link
Contributor

siewers commented May 20, 2022

Yes, it's a mess.
I would suggest to stick with the same namespace as used in the xUnit framework.

I would say in namespaces and assembly use Xunit.
In all documentation and text use xUnit.

The all lowercase version is not really used anywhere besides the xUnit assemblies, which is likely of legacy reasons.

It's basically caused by the conflict of C# using pascal case but xUnit starting with a lowercase letter which makes it a bit difficult 🙂

@StefH StefH changed the title Add WireMock.Net.xunit project Add WireMock.Net.xUnit project May 21, 2022
@StefH StefH merged commit 8d57f37 into master May 21, 2022
@StefH StefH deleted the xunit branch May 21, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants