Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove interface for all Setting classes #736

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Remove interface for all Setting classes #736

merged 1 commit into from
Mar 10, 2022

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Mar 9, 2022

No description provided.

@StefH StefH added the feature label Mar 9, 2022
@StefH StefH self-assigned this Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #736 (42882c8) into master (3087ce5) will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #736   +/-   ##
=======================================
  Coverage   75.55%   75.55%           
=======================================
  Files         175      175           
  Lines        6353     6353           
  Branches      651      651           
=======================================
  Hits         4800     4800           
  Misses       1359     1359           
  Partials      194      194           
Impacted Files Coverage Δ
src/WireMock.Net/Http/HttpClientBuilder.cs 72.41% <ø> (ø)
src/WireMock.Net/ResponseBuilders/Response.cs 95.04% <ø> (ø)
.../ResponseProviders/DynamicAsyncResponseProvider.cs 0.00% <ø> (ø)
...k.Net/ResponseProviders/DynamicResponseProvider.cs 100.00% <ø> (ø)
src/WireMock.Net/Serialization/MappingConverter.cs 60.86% <ø> (ø)
src/WireMock.Net/Server/WireMockServer.Admin.cs 57.66% <ø> (ø)
...rc/WireMock.Net/Settings/ProxyAndRecordSettings.cs 100.00% <ø> (ø)
src/WireMock.Net/Settings/WebProxySettings.cs 100.00% <ø> (ø)
...reMock.Net/Settings/WireMockCertificateSettings.cs 0.00% <ø> (ø)
...eMock.Net/Settings/WireMockServerSettingsParser.cs 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3087ce5...42882c8. Read the comment docs.

@PrzemekScott
Copy link

PrzemekScott commented Mar 10, 2022

Solution is working as expected - all settings for proxying are loaded properly, when set in appsettings.json file, at the start of the app. Thank you StefH.

image

@StefH
Copy link
Collaborator Author

StefH commented Mar 10, 2022

@PrzemekScott
A new version will be released to NuGet tomorrow.

@StefH StefH merged commit bb3147e into master Mar 10, 2022
@StefH StefH deleted the settings-class branch March 10, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants