GUID Pattern support in RegexMatcher

[brogdogg]

Adding a new RegexGuid class, extending the System.Text.RegularExpressions.Regex class, to support patterns for identifying a GUID with respect to the way the System.Guid.ToString() formats a new GUID.

Additionally, the RegexMatcher was updated to use this new RegexGuid class.

Potential use:

// Create a regex matcher with a \GUIDD pattern (i.e. only match on all caps GUID with format D
var matcher = new RegexMatcher("\GUIDD");
// Would not match, since there are lower case
double result = matcher.IsMatch("5ae7dbb5-ea2c-4c55-ac38-9634681f168d");
// Would match, as it is a valid GUID in all upper case and valid with respect o the
// format D specifer.
result = matcher.IsMatch("5AE7DBB5-EA2C-4C55-AC38-9634681F168D");

This is a suggested change to address feedback to #685

[brogdogg]

Status check shows a failed unit test. The test that failed I did not touch and when I run all tests locally I am unable to recreate the failure.

[StefH]

Sometimes that test fails... I did update that test just now

I did rerun your CI build and it is ok

Maybe you can merge latest master into your PR branch?

[StefH]

Thanks a lot.

1] take a look at my comments

2] I did not check all regex, but is there also a simple GUID match which allows any casing? Like AAAAa1ff-2f1e-4f44-a053-e2c34a7ccBBB?

3] Maybe it's good to replace all existing Regex usages in WireMock with this new one.

4] I'm thinking if we need to make using this new Regex configurable via the wiremock settings maybe?

[StefH]

An easier and (smaller code) approach on this would be to define a dictionary with the tokens and regex.
Like:

private static readonly IDictionary<string,string> _replacements = new Dictionary<string, string>
{
 { @"\guidb",  @"(\{[a-z0-9]{8}-([a-z0-9]{4}-){3}[a-z0-9]{12}\})" }, // Regular expression pattern associated with the expected format for `B` format specifier with lower case.
 // . . .
}

[StefH]

General: you can just write comments / code on 1 line, no need to break at 80 characters.

[StefH]

When using the dictionary, this can be simpler.
And a null check should be added.

private static string ReplaceGuidPattern(string pattern)
{
    Check.NotNull(pattern, nameof(pattern));

     foreach (var replacement in _replacements)
     {
         pattern = pattern.Replace(replacement.Key, replacement.Value);
     }
}

[brogdogg]

2] I did not check all regex, but is there also a simple GUID match which allows any casing? Like AAAAa1ff-2f1e-4f44-a053-e2c34a7ccBBB?

I thought about this, but since it is a Regex the ignore case operator could be used, wouldn't you think?

3] Maybe it's good to replace all existing Regex usages in WireMock with this new one.

Are you requesting I change all references to the RegexGuid class?

4] I'm thinking if we need to make using this new Regex configurable via the wiremock settings maybe?

I'm not sure what you mean here, would you be able to point to a sample? (Sorry, I'm still new to Wiremock and have only used JSON files for configuring the dotnet tool).

[StefH]

2]
You are correct

3 and 4]
Maybe better to rename RegexGuid to RegexExtended because in the future. more replacements can be added.

And maybe add an property like bool UseExtendedRegex to the settings:

• https://github.com/WireMock-Net/WireMock.Net/blob/master/src/WireMock.Net.Abstractions/Admin/Settings/SettingsModel.cs
• https://github.com/WireMock-Net/WireMock.Net/blob/master/src/WireMock.Net/Settings/WireMockServerSettings.cs
• https://github.com/WireMock-Net/WireMock.Net/blob/master/src/WireMock.Net/Settings/WireMockServerSettingsParser.cs

And the default value is set to true, but if needed, a user can set this to false.

[StefH]

@brogdogg
If you have time, can apply my comments?
Except for 3 and 4, I can also take that up once your branch is merged into master.

[brogdogg]

@brogdogg If you have time, can apply my comments? Except for 3 and 4, I can also take that up once your branch is merged into master.

Hey @StefH yeah, I was planning to address this weekend. Current job is calling for heavy hours right now. Sorry, but will look into it.