Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configure IgnoreCase in settings #695

Merged
merged 4 commits into from
Nov 29, 2021

Conversation

leolplex
Copy link
Contributor

@leolplex leolplex commented Nov 27, 2021

Hello @StefH @JanuszRybinski,

This is the PR related with this #692, the idea is allow not case sensitive in Headers, Query Params, Request Body and examples.

Regards.

@StefH StefH added the feature label Nov 27, 2021
Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to move this setting (IgnoreCase) to WireMockOpenApiParserSettings.cs to that it can be modified by user.

Default value can be set to true

@leolplex
Copy link
Contributor Author

@StefH,

you're right it's better idea, done!

@leolplex leolplex requested a review from StefH November 27, 2021 13:40
@leolplex leolplex changed the title Add IgnoreCase = true in Request body, query parameters, headers, exa… Allow configure IgnoreCase in settings Nov 27, 2021

/// <summary>
/// Is headers case sensitive? (default is true).
/// true = no case sensitive;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add these two lines:

        /// true = no case sensitive;
        /// false = case sensitive 

You can remove these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StefH Done!

@leolplex leolplex requested a review from StefH November 29, 2021 02:06
@StefH StefH merged commit 4d80eb5 into WireMock-Net:master Nov 29, 2021
@leolplex leolplex deleted the CaseNoSensitive branch December 4, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants