bug: Fix admin api client definition returning the wrong types #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- IFluentMockServerAdmin get, find and get all requests should return a log entry model - Add tests for get and find using the rest ease api client
StefH
approved these changes
Nov 19, 2017
|
Any chance of a release? |
|
Tonight |
alastairtree
deleted the
bug/admin-api-client-returns-empty-request-models
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. Been testing the use of the admin api client with RestEase and noticed that the definition has the wrong types listed as being return on the get requests API meaning the restease client has null values and some data is missing. In addition the find requests API does not return LogEntryModel like the GetRequests API instead it returns LogEntry, which I have fixed so they are all the same.