Allow to add custom service registrations when using ASP.NET Core #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@starkpl Thank you. Could you try to get the latest from my master and merge with your branch ? |
starkpl
force-pushed
the
AdditionalServiceRegistration
branch
from
20c2617
to
a1dc2ba
Compare
starkpl
force-pushed
the
AdditionalServiceRegistration
branch
from
11a98ec
to
eaa2533
Compare
|
@StefH thanks for fixing the pipeline, I rebased my branch. |
|
@starkpl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we allow to add custom middleware to WireMock's ASP.NET Core pipeline (using PreWireMockMiddlewareInit/PostWireMockMiddlewareInit), it would make sense to also allow to add custom service registration to ASP.NET Core DI. My specific use case is adding Azure Application Insights telemetry to WireMock's ASP.NET Core host to track external calls from WireMock (mappings with proxy).