Remove 2 second delay from first response and add IPv6 address support #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st from a new socket connection, only occuring on some Windows 10 machines. A side-effect of this fix is that is also allows connections to IPv6 addresses.
|
SonarCloud Quality Gate failed. |
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
==========================================
+ Coverage 75.96% 76.00% +0.03%
==========================================
Files 141 141
Lines 5463 5463
Branches 548 548
==========================================
+ Hits 4150 4152 +2
Misses 1148 1148
+ Partials 165 163 -2
Continue to review full report at Codecov.
|
StefH
changed the title
|
@benagain Thank you. |
|
Thanks for merging so quickly @StefH! It's made a great improvent to our test runs 😄 |
benagain
added a commit
to SkillsFundingAgency/das-apprentice-commitments-web
that referenced
this pull request
Mar 22, 2021
benagain
added a commit
to SkillsFundingAgency/das-apprentice-commitments-web
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #554
Remove an approximate two second delay in response to the first request from a new socket connection, apparently only occuring on some Windows 10 machines when using .Net Core.
A side-effect of this fix is that is also allows connections to IPv6 addresses.