Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WithCallback logic when using other fluent builder statements #587

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Feb 18, 2021

No description provided.

@StefH StefH added the bug label Feb 18, 2021
@StefH StefH self-assigned this Feb 18, 2021
@StefH
Copy link
Collaborator Author

StefH commented Feb 18, 2021

#569

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #587 (b6ad277) into master (e23249c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage   75.88%   75.94%   +0.05%     
==========================================
  Files         141      141              
  Lines        5437     5449      +12     
  Branches      546      546              
==========================================
+ Hits         4126     4138      +12     
  Misses       1148     1148              
  Partials      163      163              
Impacted Files Coverage Δ
src/WireMock.Net/ResponseBuilders/Response.cs 94.66% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23249c...b6ad277. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.7% 95.7% Coverage
0.0% 0.0% Duplication

@StefH StefH merged commit aa8510f into master Feb 26, 2021
@StefH StefH deleted the Fix_WithCallback branch February 26, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant