Support for partial JSON matching #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefH
requested changes
Nov 16, 2020
There was a problem hiding this comment.
Thanks,
You also need to add this new matcher to
https://github.com/WireMock-Net/WireMock.Net/blob/c02dbeb5eea5fd01ce657e8ec362fd2dddcc5b19/src/WireMock.Net/Serialization/MatcherMapper.cs
And if possible also add an unit-test for that.
|
Thanks @StefH ! Added changes as suggested. |
StefH
requested changes
Nov 16, 2020
StefH
reviewed
Nov 17, 2020
StefH
requested changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current JsonMatcher only support exact match (via JToken.DeepEquals).
This PR introduces new JsonPartialMatcher, which tolerates input properties, not existing on the Matcher value.
Example:
Matcher value {"test": "abc"} against input {"test":"abc"} is matched by both JsonMatcher and JsonPartialMatcher
Matcher value {"test":"abc"} against input {"test":"abc","other":"xyz"} is not matched by JsonMatcher, but is matched by JsonPartialMatcher
One side benefit of this PR is that JsonMatcher (and JsonPartialMatcher) are now extensible via virtual AreEqual(JToken, JToken) method.