Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET Core 3.1 example #514

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

Crossbow78
Copy link
Contributor

@Crossbow78 Crossbow78 commented Oct 3, 2020

  • Apply ILogger, IOptions, IHostedService patterns to .NET Core 3.1 example
  • Trim unnecessary bits
  • Enforce 'Out-of-process' hosting model or the example will not run correctly
  • Consolidated line-ending in two files

@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #514 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   76.00%   76.00%           
=======================================
  Files         135      135           
  Lines        5248     5248           
  Branches      517      517           
=======================================
  Hits         3989     3989           
  Misses       1105     1105           
  Partials      154      154           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0964eb2...f4534a2. Read the comment docs.

@StefH
Copy link
Collaborator

StefH commented Oct 6, 2020

@Crossbow78 Thank you very much!

@StefH StefH self-requested a review October 6, 2020 10:24
@StefH StefH merged commit 477f3b5 into WireMock-Net:master Oct 6, 2020
@Crossbow78 Crossbow78 deleted the update-netcore31-example branch October 9, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants