Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding netcoreapp3.1 as a target framework #509

Merged
merged 3 commits into from
Sep 30, 2020

Conversation

APIWT
Copy link
Contributor

@APIWT APIWT commented Sep 29, 2020

Attempting to remove a dependency on Microsoft.AspNetCore packages for projects targetting netcoreapp3.0 or greater

#507

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #509 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
- Coverage   76.01%   76.00%   -0.01%     
==========================================
  Files         135      135              
  Lines        5249     5248       -1     
  Branches      517      517              
==========================================
- Hits         3990     3989       -1     
  Misses       1105     1105              
  Partials      154      154              
Impacted Files Coverage Δ
src/WireMock.Net/Http/HttpClientHelper.cs 78.37% <ø> (ø)
src/WireMock.Net/Matchers/CSharpCodeMatcher.cs 84.84% <ø> (ø)
src/WireMock.Net/Owin/AspNetCoreSelfHost.cs 85.36% <0.00%> (-0.18%) ⬇️
...ck.Net/HttpsCertificate/ClientCertificateHelper.cs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5298b...aa7b1d0. Read the comment docs.

@StefH StefH changed the title Adding netcoreapp3.0 and netcoreapp3.1 as a target framework Adding netcoreapp3.1 as a target framework Sep 29, 2020
@StefH StefH added the feature label Sep 29, 2020
Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look

src/WireMock.Net/WireMock.Net.csproj Outdated Show resolved Hide resolved
src/WireMock.Net/WireMock.Net.csproj Outdated Show resolved Hide resolved
src/WireMock.Net/WireMock.Net.csproj Outdated Show resolved Hide resolved
src/WireMock.Net/Matchers/CSharpCodeMatcher.cs Outdated Show resolved Hide resolved
src/WireMock.Net/Http/HttpClientHelper.cs Outdated Show resolved Hide resolved
@StefH
Copy link
Collaborator

StefH commented Sep 29, 2020

CI build fails ; can you take a look?

@APIWT
Copy link
Contributor Author

APIWT commented Sep 30, 2020

@StefH It think CI is good with the exception of code coverage, the problem is I'm not sure how I reduced overall coverage. Would you mind just letting me know the best way to address it? I would be happy to add a test if necessary. If it is possible to get a MyGet build, I would happily run the Snyk scan against it!

@StefH
Copy link
Collaborator

StefH commented Sep 30, 2020

Thank you.

(The CI build did fail yesterday with a real build-error:
image
)

The Code Coverage is not blocking.

I'll take a look and create a new release NuGet (1.3.1) soon.

@APIWT
Copy link
Contributor Author

APIWT commented Sep 30, 2020

Thank you! Yeah I saw the CI fail yesterday, I assume it was something to do with the pre-feedback code using the wrong preprocessors.

Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@StefH StefH merged commit 942fc3a into WireMock-Net:master Sep 30, 2020
@StefH
Copy link
Collaborator

StefH commented Sep 30, 2020

@APIWT version 1.3.1 is released to nuget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants