Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in the WireMock.Net.FluentAssertions tests #483

Merged
merged 1 commit into from
Jul 5, 2020

Conversation

akamud
Copy link
Contributor

@akamud akamud commented Jul 4, 2020

Porting over the tests from the original project.

@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #483 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
- Coverage   75.90%   75.84%   -0.07%     
==========================================
  Files         132      136       +4     
  Lines        5089     5130      +41     
  Branches      503      504       +1     
==========================================
+ Hits         3863     3891      +28     
- Misses       1078     1092      +14     
+ Partials      148      147       -1     
Impacted Files Coverage Δ
...ssertions/Assertions/WireMockReceivedAssertions.cs 63.63% <0.00%> (ø)
....FluentAssertions/Extensions/WireMockExtensions.cs 100.00% <0.00%> (ø)
....FluentAssertions/Assertions/WireMockAssertions.cs 89.47% <0.00%> (ø)
...ons/Assertions/WireMockANumberOfCallsAssertions.cs 0.00% <0.00%> (ø)
src/WireMock.Net/Owin/HostUrlOptions.cs 95.45% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec7de4...65283e4. Read the comment docs.

@StefH
Copy link
Collaborator

StefH commented Jul 4, 2020

Maybe put the tests into separate test files? Based on the name from the class?

@akamud
Copy link
Contributor Author

akamud commented Jul 4, 2020

Can you elaborate more, please? I'm only testing the WireMockAssertions at the moment, so it is in the WireMockAssertionsTests, but since it depends on the other classes, they are covered as part of the integrated tests I wrote.

Do you mean writing separate test for the supporting classes? (WireMockReceivedAssertions, WireMockANumberOfCallsAssertions, etc.?)

@StefH
Copy link
Collaborator

StefH commented Jul 4, 2020

Correct.
Unless it does not make sense?

@akamud
Copy link
Contributor Author

akamud commented Jul 4, 2020

I think they are very simple at the moment and writing extra unit tests for them doesn't bring much value, since their behavior are guaranteed by the Assertions tests and can't be mocked at the moment.
The only part I'm not testing yet, is the Received(int numberOfCalls), but that's because I'm not using it either. They were more like a draft for the future, since I wasn't planning on writing the scenarios for asserting exactly the number of times for now.

Given that, would you like me to change anything?

@StefH
Copy link
Collaborator

StefH commented Jul 4, 2020

I will check tomorrow.

@StefH StefH merged commit 28865bd into WireMock-Net:master Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants