Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readme.md + license from mock4net #444

Merged
merged 4 commits into from
Apr 5, 2020
Merged

Add readme.md + license from mock4net #444

merged 4 commits into from
Apr 5, 2020

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Mar 25, 2020

No description provided.

@mauricel
Copy link

mauricel commented Apr 1, 2020

Firstly, I'm not a lawyer, or an expert.

However..

https://www.apache.org/foundation/license-faq.html#Distribute-changes

I'VE MADE IMPROVEMENTS TO THE APACHE CODE; MAY I DISTRIBUTE THE MODIFIED RESULT?
Absolutely -- subject to the terms of the Apache license, of course. You can give your modified code away for free, or sell it, or keep it to yourself, or whatever you like. Just remember that the original code is still covered by the Apache license and you must comply with its terms. Even if you change every single line of the Apache code you're using, the result is still based on the Foundation's licensed code. You may distribute the result under a different license, but you need to acknowledge the use of the Foundation's software. To do otherwise would be stealing.

If you think your changes would be found useful by others, though, we do encourage you to submit them to the appropriate Apache project for possible inclusion.

From the apache license...

  1. Redistribution. You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions:

You must give any other recipients of the Work or Derivative Works a copy of this License; and

Looking good so far.

You must cause any modified files to carry prominent notices stating that You changed the files;

I quickly looked but didnt see what was mock4net and what wasn't. That said, wasn't looking that hard. How do you feel about this part?

You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and

Looking good here.

If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License.

Didn't see any NOTICE text file in the original source, should be ok.

You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License.

No action required here.

@StefH
Copy link
Collaborator Author

StefH commented Apr 2, 2020

@ml-workshare Thank you for the analysis !!!
About:

I quickly looked but didnt see what was mock4net and what wasn't. That said, wasn't looking that hard. How do you feel about this part?

This I can find out (takes some searching...) and I'll add this in this PR.

@StefH
Copy link
Collaborator Author

StefH commented Apr 2, 2020

Adding a header in C# code file like this should be ok:

// This source file is based on mock4net by Alexandre Victoor which is licensed under the Apache 2.0 License.
// For more details see 'mock4net/LICENSE.txt' and 'mock4net/readme.md' in this project root.

@StefH StefH merged commit a9974a4 into master Apr 5, 2020
@StefH StefH deleted the lic branch April 5, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants