Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support int values for states and scenario naming #376

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

NoahLerner
Copy link
Member

  • Add support for submitting int values for states and scenarios
  • 1 and "1" are the same state/scenario
  • Add unit tests

@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #376 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   80.28%   80.32%   +0.03%     
==========================================
  Files         117      117              
  Lines        4692     4701       +9     
==========================================
+ Hits         3767     3776       +9     
  Misses        925      925
Impacted Files Coverage Δ
src/WireMock.Net/Server/RespondWithAProvider.cs 92.98% <100%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b323ab...1eb922a. Read the comment docs.

Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take a look at the comments?

test/WireMock.Net.Tests/WireMock.Net.Tests.csproj Outdated Show resolved Hide resolved
@NoahLerner
Copy link
Member Author

@StefH Removed dependency that I added accidentally

@StefH StefH added the feature label Nov 21, 2019
@StefH StefH merged commit 0ff23a3 into WireMock-Net:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants