Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug 301 by not setting BodyAsFile to null after first use #302

Merged
merged 3 commits into from
Jul 22, 2019
Merged

Fixed bug 301 by not setting BodyAsFile to null after first use #302

merged 3 commits into from
Jul 22, 2019

Conversation

rwwilden
Copy link
Contributor

@rwwilden rwwilden commented Jul 22, 2019

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #302 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage    80.1%   80.09%   -0.01%     
==========================================
  Files         109      109              
  Lines        4357     4356       -1     
==========================================
- Hits         3490     3489       -1     
  Misses        867      867
Impacted Files Coverage Δ
src/WireMock.Net/ResponseBuilders/Response.cs 95.19% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af46a49...99bf3cb. Read the comment docs.

@StefH StefH added the bug label Jul 22, 2019
@StefH
Copy link
Collaborator

StefH commented Jul 22, 2019

Thanks. I did add an extra unit-test to test this scenario.

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #302 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage    80.1%   80.09%   -0.01%     
==========================================
  Files         109      109              
  Lines        4357     4356       -1     
==========================================
- Hits         3490     3489       -1     
  Misses        867      867
Impacted Files Coverage Δ
src/WireMock.Net/ResponseBuilders/Response.cs 95.19% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af46a49...2e1a207. Read the comment docs.

@StefH StefH merged commit 7201479 into WireMock-Net:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants