Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Body Encoding #24

Merged
merged 2 commits into from
Feb 25, 2017
Merged

Body Encoding #24

merged 2 commits into from
Feb 25, 2017

Conversation

sbebrys
Copy link
Contributor

@sbebrys sbebrys commented Feb 23, 2017

Support custom body encoding instead default utf8

@StefH
Copy link
Collaborator

StefH commented Feb 23, 2017

Some quick remarks:

Can you please only use var for complex types ? I like to keep string, bool and byte[] for readability.

And is it usefull to expose BodyEncoding also in the admin interface?

StefH
StefH approved these changes Feb 24, 2017
View reviewed changes
Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for this PR.

A small comment would be that we need some new unit-tests to cover new functionality, but that has no high prio.

However , I want to also add opencover to this project to get more insight.

@StefH StefH merged commit 7c51b2e into WireMock-Net:master Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefH StefH StefH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbebrys @StefH