Stef negate matcher #134
Stef negate matcher #134
Conversation
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
+ Coverage 67.09% 68% +0.9%
=======================================
Files 79 80 +1
Lines 2875 2963 +88
Branches 390 394 +4
=======================================
+ Hits 1929 2015 +86
- Misses 728 731 +3
+ Partials 218 217 -1
Continue to review full report at Codecov.
|
| .WithHeader("x", "1", MatchBehaviour.RejectOnMatch) | ||
| .UsingAnyMethod()) | ||
| .RespondWith(Response.Create() | ||
| .WithBody(@"{ ""result"": ""reject""}")); |
There was a problem hiding this comment.
Shall we make this example more realistic - like the absense of an API key header returns 401 unauthorised?
| var jtoken = JToken.Parse(input); | ||
| match = IsMatch(jtoken); | ||
| } | ||
| catch (Exception) |
There was a problem hiding this comment.
Is it possible to catch the exact exception? Wouldn't want to inadvertently catch a SystemOutOfMemoryException for example.
| /// </returns> | ||
| IRequestBuilder UsingAnyVerb(); | ||
| /// <returns>The <see cref="IRequestBuilder"/>.</returns> | ||
| IRequestBuilder UsingAnyMethod(); |
There was a problem hiding this comment.
So this must be a breaking public API change? Worth obsoleting and reinstating the old one? Of following SemVer with the versioning?
There was a problem hiding this comment.
I'll add these again with [Obsolete].
| @@ -20,23 +20,24 @@ public static IMatcher Map([CanBeNull] MatcherModel matcher) | |||
| string matcherType = parts.Length > 1 ? parts[1] : null; | |||
|
|
|||
| string[] patterns = matcher.Patterns ?? new[] { matcher.Pattern }; | |||
| MatchBehaviour matchBehaviour = matcher.RejectOnMatch == true ? MatchBehaviour.RejectOnMatch : MatchBehaviour.AcceptOnMatch; | |||
There was a problem hiding this comment.
Very minor but unnecessary comparison with true here.
There was a problem hiding this comment.
It's needed because RejectOnMatch is a nullable bool.
| .UsingAnyMethod()) | ||
| .RespondWith(Response.Create() | ||
| .WithStatusCode(HttpStatusCode.Unauthorized) | ||
| .WithBody(@"{ ""result"": ""api-key missing""}")); |
There was a problem hiding this comment.
I have tweaked this example a bit - think it makes more sense now
|
Thanks for code review. and your updates. I'll merge this to main now. |
No description provided.