Implement prefix for saved mapping file #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefH
requested changes
Dec 12, 2023
test/WireMock.Net.Tests/Serialization/MappingFileNameSanitizerTests.cs
Outdated
Show resolved
Hide resolved
test/WireMock.Net.Tests/Serialization/MappingFileNameSanitizerTests.cs
Outdated
Show resolved
Hide resolved
|
Thank you for the feedback! I have addressed all comments and added an extra test for the usecase, that is going to be our primary (somehow missed in the initial implementation). Oops. I have broken a test. Looking into it. |
StefH
requested changes
Dec 13, 2023
test/WireMock.Net.Tests/Serialization/MappingFileNameSanitizerTests.cs
Outdated
Show resolved
Hide resolved
StefH
approved these changes
Dec 13, 2023
|
@StefH if it is not too much trouble, may I ask you to release the feature? I would like to start using it as soon as possible 😄 |
|
New NuGet will be released today or tomorrow. |
|
NuGet is released |
|
I will switch to the latest Wiremock.Net right away for my demo today. Thank you for expediting the release! 🎅 |
|
Ah cool. A demo for your company? |
|
More like a demo for the team inside the company 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1037