Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "blacklist" and "whitelist" terms #489

Closed
akamud opened this issue Jul 18, 2020 · 3 comments
Closed

Change "blacklist" and "whitelist" terms #489

akamud opened this issue Jul 18, 2020 · 3 comments
Assignees
Labels

Comments

@akamud
Copy link
Contributor

akamud commented Jul 18, 2020

Is your feature request related to a problem? Please describe.
These terms have proven not to be inclusive to all people in IT. A lot of big projects are already moving away from them. There are better terms that describe the intention of these lists more clearly too.

Describe the solution you'd like
A lot of repos are changing the "blacklist" term to "denylist" or "blocklist", and "whitelist" to "allowlist" or "passlist". Deny/Allow seems to be more common, though.

I know this would be a breaking change, so maybe a minor release marking these objects as Obsolete while providing the new Allow/Denylists could make this less traumatic for a possible future major release?

@akamud akamud added the feature label Jul 18, 2020
@StefH StefH self-assigned this Jul 19, 2020
@StefH
Copy link
Collaborator

StefH commented Jul 19, 2020

In WireMock.Net, I have only used the following:
https://github.com/WireMock-Net/WireMock.Net/blob/master/src/WireMock.Net/Settings/IProxyAndRecordSettings.cs#L41

/// <summary>
/// Defines a list from headers which will excluded from the saved mappings.
/// </summary>
string[] BlackListedHeaders { get; set; }

/// <summary>
/// Defines a list of cookies which will excluded from the saved mappings.
/// </summary>
string[] BlackListedCookies { get; set; }

So I guess renaming it to:
ExcludedHeaders and ExcludedCookies would be fine.

@akamud
Copy link
Contributor Author

akamud commented Jul 19, 2020

Seems fine to me, the new names are more explicit too. Other than that, I just found some references for Whitelist and Blacklist in infura.yaml, not sure what are those.

@StefH
Copy link
Collaborator

StefH commented Jul 19, 2020

Infura.yaml is just an third party example openapi yaml specification file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants