Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider port to .Net Core #23

Closed
sbebrys opened this issue Feb 22, 2017 · 7 comments
Closed

Consider port to .Net Core #23

sbebrys opened this issue Feb 22, 2017 · 7 comments

Comments

@sbebrys
Copy link
Contributor

sbebrys commented Feb 22, 2017

Hi, are You consider to port and support only .Net Standard version of this project?
I port it now to .net standard 1.3 sbebrys/WireMock.Net but You need port XPath2 too.

@StefH
Copy link
Collaborator

StefH commented Feb 22, 2017

I did consider this already : https://github.com/StefH/WireMock.Net/blob/master/src/WireMock.Net/netstandard1.3.txt

However XPath / XPath2 are both not supported on netstandard 1.3 or even not on netstandard 1.6 if I remember correctly.

Maybe the new structures in vs2017 can help/support this, but I dont think it will work.

If XPath is the only one which gives troubles, I can remove it and create a new NuGet package which is an extension on this one.

@StefH
Copy link
Collaborator

StefH commented Feb 22, 2017

Also Handlebars.Net is still old version on NuGet.

I created a PR which was merged to main, however no new NuGet yet. Maybe you can alsonssk for a new version?

@sbebrys
Copy link
Contributor Author

sbebrys commented Feb 23, 2017

Ok, so I asked Handlebars about new release and we could wait for it.

@StefH
Copy link
Collaborator

StefH commented Feb 24, 2017

Btw : The http listener is also not present in netstandard 1.3

But we can try to use this one : https://github.com/StefH/NETStandard.HttpListener

@sbebrys
Copy link
Contributor Author

sbebrys commented Feb 25, 2017

I saw that, but this version doesn't support yet ContentLength and ContentEncoding, I did workaround this by using custom headers but it isn't the best solution. In my project it satisfy me, but I don't think it is ok for everyone.

StefH added a commit that referenced this issue Apr 14, 2017
StefH added a commit that referenced this issue Apr 14, 2017
@StefH
Copy link
Collaborator

StefH commented Apr 14, 2017

Can you maybe make a PR on NETStandard.HttpListener and then move this PR into my https://github.com/StefH/WireMock.Net/tree/_stef_netstandard branch?

StefH added a commit that referenced this issue Apr 26, 2017
* #23

* #23 "Newtonsoft.Json" Version="10.0.2"

* owin

* AspNetCore

* Fix appveyor build

* fix start/stop in untitests
@StefH
Copy link
Collaborator

StefH commented Apr 26, 2017

I removed the HttpListener and used Microsoft.AspNetCore

@StefH StefH closed this as completed Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants