Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit CI shouldn't fail builds after autofixes #444

Closed
marfox opened this issue Oct 6, 2021 · 0 comments
Closed

pre-commit CI shouldn't fail builds after autofixes #444

marfox opened this issue Oct 6, 2021 · 0 comments
Labels
bug Something isn't working
Projects
v2

Comments

@marfox
Copy link
Member

marfox commented Oct 6, 2021

When submitting a new PR, the CI workflow should be:

  1. pre-commit fails the build
  2. it pushes the autofixes
  3. the build succeeds

However, point 3 doesn't happen, and the build remains failed, which is misleading.
See for instance #443.
@marfox marfox added the bug Something isn't working label Oct 6, 2021
@marfox marfox added this to To do in v2 via automation Oct 6, 2021
@marfox marfox moved this from To do to Doing in v2 Oct 6, 2021
@marfox marfox closed this as completed in 1b004a0 Oct 6, 2021
v2 automation moved this from Doing to Done Oct 6, 2021
marfox added a commit that referenced this issue Oct 15, 2021
@marfox
disable Black, closes #444
6db4542 
Code is too vertical, always having one symbol per line doesn't make it
more readable.
It also conflicts with isort, making pre-commit CI fail builds forever.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
v2
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marfox