Update WikibaseRepo::getEntityNamespaceLookup() call #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: T277313 Depends-On: Ief409a501aac74e7b6df4e440113cd552dba3c74
|
Let me once that's merged and I'll merge this one. (Sidenote: We should clean up travis here). |
itamargiv
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
LGTM, I'll adhere to what @Ladsgroup said before though, The base change in WB is merged now.
|
Yeah, tbh I’m not sure what we do with this extension in general (does it still work? I haven’t used it in a long time). But I guess we can at least merge this change, as long as there’s no expectation that WikibaseImport works with older MediaWiki/Wikibase versions. |
|
Let's merge it for now as it's trivial enough. Let's make a ticket for determining future of it. |
|
There is this popular Wikibase Docker bundle by wmde which uses Mediawiki 1.35. WikibaseImport will work with this bundle when checking out c1233da. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T277313
Depends-On: Ief409a501aac74e7b6df4e440113cd552dba3c74