Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User control for number of results per page #57

Closed
mkroetzsch opened this issue May 16, 2016 · 1 comment
Closed

User control for number of results per page #57

mkroetzsch opened this issue May 16, 2016 · 1 comment
Assignees
Labels
enhancement New feature or request view: Query This relates to the query view

Comments

@mkroetzsch
Copy link
Member

It is sometimes handy to show a big number of results per page (e.g., to use browsers text search for a particular string in descriptions). It would be good if the pager could support this and the query vuew could have controls to select how many results to show per page. A few choices would be enough, maybe: 15 (default, fits most screens), 50 (max. number of labels that can be fetched in one API request), 1000 (if this still works fast enough in browsers, otherwise maybe use 500 or 250 as a max).

This choice would be the same no matter how queries are created (run mode or query builder). The control for this should use only little space.

@mkroetzsch mkroetzsch added the enhancement New feature or request label May 16, 2016
@mkroetzsch mkroetzsch added the view: Query This relates to the query view label May 27, 2016
@mkroetzsch mkroetzsch changed the title Query: user control for number of results per page User control for number of results per page May 27, 2016
arsylum added a commit that referenced this issue Jun 14, 2016
@arsylum
Copy link
Collaborator

arsylum commented Jun 14, 2016

This is now implemented as a directive for use within PaginationController. I used a hybrid widget that allows selection of proposed values (default 15,50,1000) as well as entering arbitrary numbers. The query-run branch has a working example of this widget.

Possible values are currently enforced to a range of [3;2000]. While 2000 is pushing it, the app still performs surprisingly responsive with 1000 rows. I have a decent amount of RAM though.

It's not unthinkable to allow higher values as well, but that would call for some safety measure so users won't accidentally freeze their browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request view: Query This relates to the query view
Projects
None yet
Development

No branches or pull requests

2 participants