Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation for Swedish #130

Closed
salgo60 opened this issue Apr 2, 2018 · 4 comments
Closed

Missing translation for Swedish #130

salgo60 opened this issue Apr 2, 2018 · 4 comments
Labels
help wanted Extra attention is needed i18n/l10n Internationalisation / Languages / Translation
Milestone

Comments

@salgo60
Copy link

salgo60 commented Apr 2, 2018

I get
SEC_LINKS
EDITS.EDIT_LABEL
SEC_LINKS.WIKIDATA
SEC_LINKS.REASONATOR
SEC_IDENTIFIERS...

on URL with lang=sv eg. https://tools.wmflabs.org/sqid/#/view?id=Q47465296&lang=sv

When I was in Berlin one of the developer told me that maybe lang=sv should fix that but it doesn't.....

See video how it looks....

@mmarx mmarx added help wanted Extra attention is needed i18n/l10n Internationalisation / Languages / Translation labels Apr 3, 2018
@mmarx
Copy link
Member

mmarx commented Apr 3, 2018

Thanks for reporting the issue. The problem is that we're currently missing translated strings for the UI in Swedish. In theory, the fallback option should be the English translation rather than just showing the untranslated message labels, but this seems not to work reliably. I'll have a look into that.

Would you be interested in helping us with the translation? Essentially, we'd need a Swedish phrase corresponding to each entry of src/lang/en.json.

@mmarx mmarx changed the title Labels are not always translated to Swedish Missing translation for Swedish Apr 3, 2018
mmarx added a commit that referenced this issue Apr 4, 2018
As noticed in issue #130, translation fallback did not work if `lang`
was set to something that we do not have translations for.
@mmarx
Copy link
Member

mmarx commented Apr 4, 2018

The fallback to English should now be working correctly again (you might need to do a hard reload to get the new code).

@salgo60
Copy link
Author

salgo60 commented Apr 4, 2018

Thanks the Swedish translation file is on its way....

mmarx added a commit that referenced this issue Apr 5, 2018
As noticed in issue #130, translation fallback did not work if `lang`
was set to something that we do not have translations for.
@mmarx mmarx added this to To do in General Development via automation Aug 20, 2019
@mmarx
Copy link
Member

mmarx commented Aug 20, 2019

Should be covered by #71.

@mmarx mmarx closed this as completed Aug 20, 2019
General Development automation moved this from To do to Done Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed i18n/l10n Internationalisation / Languages / Translation
Projects
Development

No branches or pull requests

2 participants