Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search doesn't work when using Dutch translation #129

Closed
sjoerddebruin opened this issue Feb 12, 2018 · 1 comment
Closed

Search doesn't work when using Dutch translation #129

sjoerddebruin opened this issue Feb 12, 2018 · 1 comment
Assignees
@mmarx
Labels
bug Something isn't working view: Browse This relates to the browsing view

Comments

@sjoerddebruin
Copy link
Member

Probably the difference in language codes: SQID used NL_nl while Wikidata just uses NL.
@mmarx mmarx added bug Something isn't working view: Browse This relates to the browsing view labels Feb 12, 2018
@mmarx mmarx self-assigned this Feb 12, 2018
@mmarx mmarx closed this as completed in b9d1c9b Feb 14, 2018
@mmarx mmarx reopened this Feb 14, 2018
mmarx added a commit that referenced this issue Feb 14, 2018
@mmarx
Actually fix the search function
8db51d3 
This fixes the original issue of #129.
@mmarx
Copy link
Member

mmarx commented Feb 14, 2018

Okay, now also the search box should work.

@mmarx mmarx closed this as completed Feb 15, 2018
mmarx added a commit that referenced this issue Apr 5, 2018
@mmarx
Handle translations that do not exactly match mwapi language codes
dfe61ed 
Fixes #129.
mmarx added a commit that referenced this issue Apr 5, 2018
@mmarx
Actually fix the search function
3bb7729 
This fixes the original issue of #129.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmarx mmarx

Labels
bug Something isn't working view: Browse This relates to the browsing view
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmarx @sjoerddebruin