Don't use base except clauses

WhyNotHugo · May 11, 2018 · f6a773f · f6a773f
1 parent 6126659
commit f6a773f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/caffeine/main.py b/caffeine/main.py
@@ -447,7 +447,7 @@ def main():
  try:
  hours = int(parts[0])
  minutes = int(parts[1])
- except:
+ except ValueError:
  print("Invalid time argument.")
  sys.exit(2)
 

diff --git a/caffeine/utils.py b/caffeine/utils.py
@@ -42,12 +42,12 @@ def getProcesses():
  for pid in os.listdir("/proc/"):
  try:
  pid = int(pid)
- except:
+ except ValueError:
  continue
 
  try:
  processName = getProcessName(pid).lower()
- except:
+ except Exception:
  continue
 
  processList.append((processName, pid))

diff --git a/scripts/generate_pot.py b/scripts/generate_pot.py
@@ -105,7 +105,7 @@ def scan(nodelist):
  try:
  try:
  return scan(parse(fp.read()))
- except:
+ except Exception:
  print('Syntax Error in file %r' % filename, file=sys.stderr)
  finally:
  fp.close()
@@ -115,7 +115,7 @@ def scan_glade_file(filename):
  """Scan a glade file for translatable strings."""
  try:
  doc = minidom.parse(filename)
- except:
+ except Exception:
  print('Syntax Error in file %r' % filename, file=sys.stderr)
  for element in doc.getElementsByTagName('property'):
  if element.getAttribute('translatable') == 'yes':