Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add termination_grace_period_seconds, change default interval #26

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

Wh1isper
Copy link
Owner

Description

Motivation and Context

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.68%. Comparing base (b25f192) to head (ab92b9e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files          30       30           
  Lines        1342     1342           
=======================================
  Hits         1123     1123           
  Misses        219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wh1isper Wh1isper changed the title Add termination_grace_period_seconds Add termination_grace_period_seconds, change default daemon Jul 16, 2024
@Wh1isper Wh1isper changed the title Add termination_grace_period_seconds, change default daemon Add termination_grace_period_seconds, change default interval Jul 16, 2024
@Wh1isper Wh1isper merged commit f415a6b into main Jul 16, 2024
17 checks passed
@Wh1isper Wh1isper deleted the feature-grace-terminate branch July 16, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant