Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary files, change ga to modify score.py for lab #1

Merged
merged 4 commits into from
Sep 28, 2021

Conversation

WesleyCh3n
Copy link
Owner

Change log

  • remove template folder, update download link in ga
  • suggestion: using sed replace score for lab

@WesleyCh3n
Copy link
Owner Author

hello @csinrn
I saw what score_lab.py do, and that's a great update in ga~
But I slightly replace the thought with sed.
So that it's no need to create score_lab.py but modify the score in score.py directly for lab.

You can checkout Files changed button to see what lines I modified.
And if you think it's ok, then u can press the Merge pull request XD

Thanks!

@csinrn
Copy link
Collaborator

csinrn commented Sep 28, 2021

hello @WesleyCh3n
I've viewed all the commits. It's a great adjust, and it do make the whole project more concise and improve the overall readability.
It will definitely get 30 out of 30 in the Design/Readability assessment. 😆

Thanks a lot!

@csinrn csinrn merged commit c5bf267 into master Sep 28, 2021
@csinrn csinrn deleted the beta branch September 28, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants