Consistently use the test sets as reference for gap_before
and gap_after
#45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two ways of defining a derived cross-validator. One is to redefine
_iter_test_indices
or_iter_test_masks
(test viewpoint), and the other is to redefine_iter_train_masks
or_iter_train_indices
(train viewpoint).Currently, these two methods assign different semantic meanings to the parameters
gap_before
andgap_after
. The test viewpoint uses the test sets as the reference:The train viewpoint uses the training sets as the reference:
This diverged behavior is
not intendedinappropriate. The package should insist on the test viewpoint, and hence this PR. It will be enforced inv0.2
.I don't think this issue has touched any users, for the derived classes in this package use
_iter_test_indices
exclusively (test viewpoint). No users have reported this issue either. If you suspect that you have been affected by it, please reply to this PR.