Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in gene_random_walk, import pyg only when initing Raindrop, and make MultiHeadAttention work with all attention operators #384

Merged
merged 4 commits into from
May 6, 2024

Conversation

WenjieDu
Copy link
Owner

@WenjieDu WenjieDu commented May 6, 2024

What does this PR do?

  1. fixing a bug in gene_random_walk that train_X_ori and val_X_ori didn't get standardized;
  2. fixing Only reminder missing torch_geometric when initializing Raindrop #380;
  3. fixing Make MultiHeadAttention to work with all attention operators #382;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

train_X_ori and val_X_ori didn't get standardized, fix in this PR
Enable all attention operators to work with `MultiHeadAttention`
@WenjieDu WenjieDu marked this pull request as ready for review May 6, 2024 04:14
@WenjieDu WenjieDu merged commit 1f5f4f9 into main May 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant