Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CSDI as a forecasting model #354

Merged
merged 11 commits into from
Apr 18, 2024
Merged

Implement CSDI as a forecasting model #354

merged 11 commits into from
Apr 18, 2024

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. making pypots.data.BaseDataset to return X_pred for forecasting;
  2. fixing Possible to implement CSDI as a forecasting model for POTS data #264;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu
feat: enable pypots.data.BaseDataset to return X_pred for forecasting;
be497bc
@WenjieDu
test: save data for forecasting into hdf5 files;
57df61e
@WenjieDu
fix: mistaken variables;
68fe7f3
@WenjieDu
fix: return train_X_ori in gene_random_walk();
0ec913b
@WenjieDu
refactor: rename check_X_ori_in_val_set() into key_in_data_set();
2ed66fb
@WenjieDu
refactor: simplify BackboneCSDI;
2e68f73
@WenjieDu
feat: add CSDI as a forecasting model;
2f2fc60
@WenjieDu
Merge branch 'dev' into (feat)csdi_forecasting
f848dd4
@WenjieDu
refactor: simplify CSDI imputation and forecasting models;
1712f1c
@WenjieDu
refactor: simplify TestDatasetForCSDI;
0932c4c
@WenjieDu
Fix failed doc building, fix a bug in gene_random_walk(), and refacto…
fa32fb2 
…r unit testing configs (#355)

* docs: fix sphinx==7.2.6 to avoid an error when sphinx upgrades to 7.3.6;

* test: refactor CI testing configs;

* fix: bug in gene_random_walk();

* fix: delete possible caches before testing dataset generation;
@coveralls
Copy link
Collaborator

coveralls commented Apr 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8733184563

Details

  • 568 of 635 (89.45%) changed or added relevant lines in 56 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 81.035%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/data/checking.py 6 7 85.71%
pypots/forecasting/csdi/core.py 56 57 98.25%
pypots/forecasting/csdi/data.py 82 101 81.19%
pypots/forecasting/csdi/model.py 115 135 85.19%
pypots/data/dataset/base.py 134 160 83.75%
Files with Coverage Reduction New Missed Lines %
pypots/utils/metrics/error.py 1 70.37%
pypots/clustering/vader/model.py 1 84.85%
Totals Coverage Status
Change from base Build 8724993112: 0.3%
Covered Lines: 7345
Relevant Lines: 9064
💛 - Coveralls

@WenjieDu WenjieDu merged commit 88ec17b into dev Apr 18, 2024
8 checks passed
@WenjieDu WenjieDu deleted the (feat)csdi_forecasting branch April 18, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WenjieDu @coveralls